jessicajones Posted February 15, 2020 Share Posted February 15, 2020 Hi Are feature requests possible? I would like to have a new weather type: snow. This will occur only during the typical months in winter. It could have 2 forms: small and big snowflakes. thx Link to comment
X7123M3-256 Posted February 15, 2020 Share Posted February 15, 2020 (edited) Feature requests are better posted on the Github issue page. You can post them here but not all the developers will check this forum regularly. You can also have a go at implementing this yourself and then submit a pull request - it doesn't sound too hard. Someone did make something similar, but that's just changing the ground texture. Edited February 15, 2020 by X7123M3-256 Link to comment
jessicajones Posted February 15, 2020 Author Share Posted February 15, 2020 Can you put it on github? I don't know anything about github. Link to comment
X7123M3-256 Posted February 15, 2020 Share Posted February 15, 2020 (edited) Looks like it was already suggested, and actually implemented, but was never merged. See https://github.com/OpenRCT2/OpenRCT2/pull/3636. Since there doesn't seem to be an open issue for this you could still submit another if you wanted - that was back in 2016.. Edited February 15, 2020 by X7123M3-256 Link to comment
jessicajones Posted February 15, 2020 Author Share Posted February 15, 2020 why is it made and not added? Sorry this github is a mystery for me. I have no idea what to ask there and prefer to stay away there because I don't know how it works. Can you ask a developer if he can add it? It's already made you tell me! Link to comment
X7123M3-256 Posted February 16, 2020 Share Posted February 16, 2020 14 minutes ago, jessicajones said: I have no idea what to ask there Just write a brief description of the feature, suggestion, bug, or whatever. You may want to include the link to the old issue for context. If you report a bug make sure you specify the version of the game you are using and the steps needed to reproduce it, otherwise the bug report is of little use. 4 minutes ago, jessicajones said: why is it made and not added? From what I can tell, the guy who made it submitted a PR, but there were issues, and he ended up deleting it instead of fixing them. It's sometimes the case that a PR is submitted, but there are problems (e.g it doesn't merge cleanly with develop, doesn't compile on all platforms, etc), and can't be merged straight away. I had a feature I implemented to let you change the speed of powered rides, which was never merged because I messed up the rebase and never got around to creating a new PR. 8 minutes ago, jessicajones said: Can you ask a developer if he can add it? As far as I can tell, the guy who submitted it later deleted the code (not sure why), and it was not suitable for merging in its current state anyway. If it was just a matter of merging it, that would have been done back then, there was still more work required. Also, this was in 2016, and the codebase has changed a lot since then (back then it was mostly C, it's now C++), so a refactor would likely be required. Also, I am no more capable of asking the developers things as you are. 1 Link to comment
jessicajones Posted February 16, 2020 Author Share Posted February 16, 2020 Hi Can you develop it yourself too? I now added a new issue on github Link to comment
X7123M3-256 Posted February 16, 2020 Share Posted February 16, 2020 I don't plan to implement this right now - I have my own feature that I'm working on at the moment and it's likely to be a while before I'm done with that. This doesn't look like an especially difficult thing to do though, especially as the game apparently already has the snow sprite. Maybe when I'm done with the custom track I could have a look at it (and resubmit my old code for the powered ride cheat). I can see the issue you opened but it was closed as a duplicate. Sorry about that, I told you it wasn't a duplicate because the issue I found had been closed, but there was an even earlier open issue from 2015 that I'd missed. Link to comment
jessicajones Posted February 16, 2020 Author Share Posted February 16, 2020 GREAT! I would be very happy and praise you when you want to make the snow!! 😉 I just would LOVE to build a snow covered park, with christmas rides you can find on the custom rides forum AND with snow enabled! I hope you want to make it when you have free time. Link to comment
X7123M3-256 Posted February 16, 2020 Share Posted February 16, 2020 You can already make snowy parks, there's a snow land texture and some snowy trees. Here's an example from H2H8. I think this would be a nice feature and totally feasible, but it's unlikely I'll do it anytime soon because I have so much other stuff I'm trying to work on, and I tend to never finish projects. 1 Link to comment
jessicajones Posted February 16, 2020 Author Share Posted February 16, 2020 finish first the snow and then the others hehe just kidding 😁😁😁 Link to comment
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now